Re: [RFA-v2] Handle cygwin wchar_t specifics

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Sat, 16 Apr 2011 23:28:35 +0200, Pierre Muller wrote:
> --- config.in	17 Mar 2011 13:19:09 -0000	1.125
> +++ config.in	16 Apr 2011 21:19:47 -0000
> --- configure	17 Mar 2011 13:19:09 -0000	1.329
> +++ configure	16 Apr 2011 21:19:52 -0000

You do not have to post autogenerated files here, it was posted only due to
your request for your convenience before.


> --- gdb_wchar.h	1 Jan 2011 15:33:05 -0000	1.6
> +++ gdb_wchar.h	16 Apr 2011 21:19:57 -0000
> @@ -60,6 +60,7 @@
>  
>  #include <wchar.h>
>  #include <wctype.h>
> +#include "config.h"

I would say rather #include "defs.h" and as the first #include line.


> +#define STR_VAL1(X) #X
> +#define STR_VAL(X) STR_VAL1(X)

This is called XSTRING in include/symcat.h.


> +#define SIZEOF_WCHAR_T_STR STR_VAL(SIZEOF_WCHAR_T)
                                    ^^ space - coding style


> -/* If __STDC_ISO_10646__ is defined, then the host wchar_t is UCS-4.
> +/* If __STDC_ISO_10646__ is defined, then the host wchar_t is UCS-4 or
> UCS-2.

Corrupted diff by your mailer word wrapping.


These are just technical notes, no real review/approval.


Thanks,
Jan