From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27940 invoked by alias); 16 Apr 2011 22:35:25 -0000 Received: (qmail 27838 invoked by uid 22791); 16 Apr 2011 22:35:23 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Apr 2011 22:35:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3GMZ1TM006329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 16 Apr 2011 18:35:01 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3GMYwLv025133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 16 Apr 2011 18:35:00 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p3GMYwgv024122; Sun, 17 Apr 2011 00:34:58 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p3GMYvqn024120; Sun, 17 Apr 2011 00:34:57 +0200 Date: Sat, 16 Apr 2011 22:35:00 -0000 From: Jan Kratochvil To: Pierre Muller Cc: "'Tom Tromey'" , gdb-patches@sourceware.org Subject: Re: [RFA-v2] Handle cygwin wchar_t specifics Message-ID: <20110416223456.GA23619@host1.jankratochvil.net> References: <5928.31498147479$1302882967@news.gmane.org> <005101cbfc50$193136b0$4b93a410$@muller@ics-cnrs.unistra.fr> <20110416162455.GA5599@host1.jankratochvil.net> <000001cbfc7d$3f67f440$be37dcc0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001cbfc7d$3f67f440$be37dcc0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00258.txt.bz2 On Sat, 16 Apr 2011 23:28:35 +0200, Pierre Muller wrote: > --- config.in 17 Mar 2011 13:19:09 -0000 1.125 > +++ config.in 16 Apr 2011 21:19:47 -0000 > --- configure 17 Mar 2011 13:19:09 -0000 1.329 > +++ configure 16 Apr 2011 21:19:52 -0000 You do not have to post autogenerated files here, it was posted only due to your request for your convenience before. > --- gdb_wchar.h 1 Jan 2011 15:33:05 -0000 1.6 > +++ gdb_wchar.h 16 Apr 2011 21:19:57 -0000 > @@ -60,6 +60,7 @@ > > #include > #include > +#include "config.h" I would say rather #include "defs.h" and as the first #include line. > +#define STR_VAL1(X) #X > +#define STR_VAL(X) STR_VAL1(X) This is called XSTRING in include/symcat.h. > +#define SIZEOF_WCHAR_T_STR STR_VAL(SIZEOF_WCHAR_T) ^^ space - coding style > -/* If __STDC_ISO_10646__ is defined, then the host wchar_t is UCS-4. > +/* If __STDC_ISO_10646__ is defined, then the host wchar_t is UCS-4 or > UCS-2. Corrupted diff by your mailer word wrapping. These are just technical notes, no real review/approval. Thanks, Jan