Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Remove old Cygwin1.5 support
Date: Thu, 07 Apr 2011 21:24:00 -0000	[thread overview]
Message-ID: <20110407212438.GA18550@ednor.casa.cgf.cx> (raw)
In-Reply-To: <004e01cbf4ae$1cea8710$56bf9530$@muller@ics-cnrs.unistra.fr>

On Thu, Apr 07, 2011 at 12:58:14AM +0200, Pierre Muller wrote:
>As Christopher Faylor told me that my previous patch series 
>was much too bulky compared to the added value,
>I will try to split it in little parts.
>
>The first two patches concern the removal of Cygwin 1.5 support has he
>suggested. This allows some simplifications in windows-nat.c code
>and I will try to further reduce cygwin/mingw differences in subsequent 
>patches.
>
>This first part just removes the macros that are used to support Cygwin 1.5
>in remote-fileio.c and windows-nat.c
>The second part updates gdbserver/win32-low.c to use the
>new cygwin_conv_path and cygwin_conv_path_list functions
>in order to avoid build failure due to deprecated warning.
>
>Does anyone object to the idea of removing old Cygwin support?
>Christopher, is this patch acceptable as is?
>
>Pierre Muller.
>
>2011-04-07  Pierre Muller  <muller@ics.u-strasbg.fr>
>
>	Remove support for old Cygwin 1.5 versions.
>	* remote-fileio.c: Remove macros used to emulate new
>cygwin_conv_path
>	function on old Cygwin version.
>	* windows-nat.c: Remove cygwin version check and always define
>	__USEWIDE for Cygwin compilation.

Looks good.  Please check in.  I can't approve the gdbserver patch since
I don't believe I have that privilege.

cgf


  reply	other threads:[~2011-04-07 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 22:58 Pierre Muller
2011-04-07 21:24 ` Christopher Faylor [this message]
2011-04-07 22:27   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110407212438.GA18550@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox