From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9014 invoked by alias); 7 Apr 2011 21:24:46 -0000 Received: (qmail 9004 invoked by uid 22791); 7 Apr 2011 21:24:44 -0000 X-SWARE-Spam-Status: No, hits=1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from nm24-vm0.bullet.mail.ac4.yahoo.com (HELO nm24-vm0.bullet.mail.ac4.yahoo.com) (98.139.53.222) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Thu, 07 Apr 2011 21:24:40 +0000 Received: from [98.139.52.197] by nm24.bullet.mail.ac4.yahoo.com with NNFMP; 07 Apr 2011 21:24:39 -0000 Received: from [74.6.228.50] by tm10.bullet.mail.ac4.yahoo.com with NNFMP; 07 Apr 2011 21:24:39 -0000 Received: from [127.0.0.1] by smtp109.mail.ac4.yahoo.com with NNFMP; 07 Apr 2011 21:24:39 -0000 Received: from cgf.cx (cgf@96.252.118.15 with login) by smtp109.mail.ac4.yahoo.com with SMTP; 07 Apr 2011 14:24:39 -0700 PDT X-Yahoo-SMTP: jenXL62swBAWhMTL3wnej93oaS0ClBQOAKs8jbEbx_o- Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id A56D74A801A for ; Thu, 7 Apr 2011 17:24:38 -0400 (EDT) Date: Thu, 07 Apr 2011 21:24:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Remove old Cygwin1.5 support Message-ID: <20110407212438.GA18550@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <004e01cbf4ae$1cea8710$56bf9530$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <004e01cbf4ae$1cea8710$56bf9530$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00113.txt.bz2 On Thu, Apr 07, 2011 at 12:58:14AM +0200, Pierre Muller wrote: >As Christopher Faylor told me that my previous patch series >was much too bulky compared to the added value, >I will try to split it in little parts. > >The first two patches concern the removal of Cygwin 1.5 support has he >suggested. This allows some simplifications in windows-nat.c code >and I will try to further reduce cygwin/mingw differences in subsequent >patches. > >This first part just removes the macros that are used to support Cygwin 1.5 >in remote-fileio.c and windows-nat.c >The second part updates gdbserver/win32-low.c to use the >new cygwin_conv_path and cygwin_conv_path_list functions >in order to avoid build failure due to deprecated warning. > >Does anyone object to the idea of removing old Cygwin support? >Christopher, is this patch acceptable as is? > >Pierre Muller. > >2011-04-07 Pierre Muller > > Remove support for old Cygwin 1.5 versions. > * remote-fileio.c: Remove macros used to emulate new >cygwin_conv_path > function on old Cygwin version. > * windows-nat.c: Remove cygwin version check and always define > __USEWIDE for Cygwin compilation. Looks good. Please check in. I can't approve the gdbserver patch since I don't believe I have that privilege. cgf