Re: [PATCH] remote target interrupt before ack

[Pedro Alves <pedro@codesourcery.com>]

On Monday 04 April 2011 21:38:32, Michael Walle wrote:
> Am Montag 04 April 2011, 22:21:21 schrieb Pedro Alves:
> > On Monday 04 April 2011 21:00:15, Michael Walle wrote:
> > > the following patch puts the sending of the interrupt/break sequence
> > > before the proforma ACK. This guarantees the ACK won't be delivered to
> > > an application on the remote side.
> 
> > 
> > Can you explain what the latter sentence means a bit better?
> > 
> Oh, i forgot to mention that this bug affects serial lines which are shared 
> with the GDB stub. Assume the remote needs a BREAK to start its gdb stub. If 
> you send the '+' before the BREAK it will be delivered to the actual 
> application running on the device (and of course listening on the serial 
> port). [If there happens to be some echo service things will even go worse, 
> because the echoed '+' will be interpreted by GDB as an ACK to the first sent 
> packet.]

Okay, makes sense.  I figured it was something like that, but doesn't hurt
to be explicit so we don't have to guess, and for the benefit of
the archives.

Patch is okay, thanks.

-- 
Pedro Alves