From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Walle <michael@walle.cc>
Subject: Re: [PATCH] remote target interrupt before ack
Date: Mon, 04 Apr 2011 20:21:00 -0000 [thread overview]
Message-ID: <201104042121.22036.pedro@codesourcery.com> (raw)
In-Reply-To: <201104042200.15473.michael@walle.cc>
On Monday 04 April 2011 21:00:15, Michael Walle wrote:
> Hi,
>
> the following patch puts the sending of the interrupt/break sequence before
> the proforma ACK. This guarantees the ACK won't be delivered to an application
> on the remote side.
Can you explain what the latter sentence means a bit better?
--
Pedro Alves
>
>
> --- remote.c.orig 2011-04-03 22:01:56.000000000 +0200
> +++ remote.c 2011-04-03 22:02:02.000000000 +0200
> @@ -2948,12 +2948,12 @@
>
> immediate_quit++; /* Allow user to interrupt it. */
>
> - /* Ack any packet which the remote side has already sent. */
> - serial_write (remote_desc, "+", 1);
> -
> if (interrupt_on_connect)
> send_interrupt_sequence ();
>
> + /* Ack any packet which the remote side has already sent. */
> + serial_write (remote_desc, "+", 1);
> +
> /* The first packet we send to the target is the optional "supported
> packets" request. If the target can answer this, it will tell us
> which later probes to skip. */
>
next prev parent reply other threads:[~2011-04-04 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 20:00 Michael Walle
2011-04-04 20:21 ` Pedro Alves [this message]
2011-04-04 20:38 ` Michael Walle
2011-04-05 16:10 ` Pedro Alves
2011-04-26 11:01 ` Michael Walle
2011-04-26 15:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104042121.22036.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox