From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: bauerman@br.ibm.com (Thiago Jung Bauermann),
gdb-patches@sourceware.org (gdb-patches ml)
Subject: Re: [RFA] Refactor breakpoint_re_set_one
Date: Tue, 29 Mar 2011 12:36:00 -0000 [thread overview]
Message-ID: <201103291221.p2TCLYGp020110@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20110328212651.GG3670@adacore.com> from "Joel Brobecker" at Mar 28, 2011 02:26:51 PM
Joel Brobecker wrote:
> > 2011-03-28 Thiago Jung Bauermann <bauerman@br.ibm.com>
> >
> > * breakpoint.c (breakpoint_re_set_one): Factor out breakpoint-resetting
> > code from here ...
> > (re_set_breakpoint): ... to here ...
> > (addr_string_to_sals): ... and here.
>
> This looks very good to me!
FWIW this looks good to me as well ...
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-03-29 12:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 15:18 Thiago Jung Bauermann
2011-03-28 20:08 ` Joel Brobecker
2011-03-28 20:24 ` Pedro Alves
2011-03-29 1:40 ` Thiago Jung Bauermann
2011-03-29 1:55 ` Joel Brobecker
2011-03-29 12:36 ` Ulrich Weigand [this message]
2011-03-31 14:46 ` Thiago Jung Bauermann
2011-03-31 14:37 ` [commit] Fix uninitialized warning (Re: [RFA] Refactor breakpoint_re_set_one) Ulrich Weigand
2011-03-31 15:03 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103291221.p2TCLYGp020110@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=bauerman@br.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox