From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3881 invoked by alias); 29 Mar 2011 12:21:49 -0000 Received: (qmail 3815 invoked by uid 22791); 29 Mar 2011 12:21:46 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate5.uk.ibm.com (HELO mtagate5.uk.ibm.com) (194.196.100.165) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Mar 2011 12:21:39 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p2TCLb5P028248 for ; Tue, 29 Mar 2011 12:21:37 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2TCMATL1405112 for ; Tue, 29 Mar 2011 13:22:10 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2TCLa3w020192 for ; Tue, 29 Mar 2011 06:21:36 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p2TCLYGp020110; Tue, 29 Mar 2011 06:21:35 -0600 Message-Id: <201103291221.p2TCLYGp020110@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 29 Mar 2011 14:21:34 +0200 Subject: Re: [RFA] Refactor breakpoint_re_set_one To: brobecker@adacore.com (Joel Brobecker) Date: Tue, 29 Mar 2011 12:36:00 -0000 From: "Ulrich Weigand" Cc: bauerman@br.ibm.com (Thiago Jung Bauermann), gdb-patches@sourceware.org (gdb-patches ml) In-Reply-To: <20110328212651.GG3670@adacore.com> from "Joel Brobecker" at Mar 28, 2011 02:26:51 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01167.txt.bz2 Joel Brobecker wrote: > > 2011-03-28 Thiago Jung Bauermann > > > > * breakpoint.c (breakpoint_re_set_one): Factor out breakpoint-resetting > > code from here ... > > (re_set_breakpoint): ... to here ... > > (addr_string_to_sals): ... and here. > > This looks very good to me! FWIW this looks good to me as well ... Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com