From: Pedro Alves <pedro@codesourcery.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [patch gdb]: Fix some DOS-path related issues in gdb
Date: Wed, 23 Mar 2011 15:29:00 -0000 [thread overview]
Message-ID: <201103231444.34735.pedro@codesourcery.com> (raw)
In-Reply-To: <AANLkTi=dDbQCEwNz_m=G7Uw59mbZCRZOPAXErhaRnY7L@mail.gmail.com>
On Wednesday 23 March 2011 14:07:01, Kai Tietz wrote:
> @@ -1023,12 +1025,13 @@ elfstab_offset_sections (struct objfile
> struct stab_section_info *maybe = dbx->stab_section_info;
> struct stab_section_info *questionable = 0;
> int i;
> - char *p;
> + const char *p;
>
> /* The ELF symbol info doesn't include path names, so strip the path
> (if any) from the psymtab filename. */
> - while (0 != (p = strchr (filename, '/')))
> - filename = p + 1;
> + p = lbasename (filename);
> + if (p != filename)
> + filename = p;
These three lines are the same as just:
filename = lbasename (filename);
You can then drop the unnecessary `p' local.
The patch looked good to me with that change.
--
Pedro Alves
next prev parent reply other threads:[~2011-03-23 14:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTi=QoOiBg3XmMv+hRNe8DkT2YiVGZ=7NhaQwzCey@mail.gmail.com>
2011-03-03 12:10 ` Kai Tietz
2011-03-03 13:24 ` Eli Zaretskii
2011-03-03 13:48 ` Kai Tietz
2011-03-03 14:00 ` Eli Zaretskii
2011-03-03 14:58 ` Joel Brobecker
2011-03-03 15:25 ` Kai Tietz
2011-03-03 15:32 ` Pedro Alves
2011-03-03 15:41 ` Kai Tietz
2011-03-03 16:09 ` Pedro Alves
2011-03-03 16:19 ` Kai Tietz
2011-03-03 16:42 ` Pedro Alves
2011-03-03 17:32 ` Kai Tietz
2011-03-04 7:23 ` Vladimir Simonov
2011-03-04 8:23 ` Joel Brobecker
2011-03-07 19:28 ` Jan Kratochvil
2011-03-07 19:28 ` Pedro Alves
2011-03-07 19:34 ` Jan Kratochvil
2011-03-03 18:09 ` Eli Zaretskii
2011-03-04 5:12 ` Joel Brobecker
2011-03-04 13:05 ` André Pönitz
2011-03-04 9:48 ` Kai Tietz
2011-03-04 10:37 ` Mark Kettenis
2011-03-05 9:13 ` Kai Tietz
2011-03-05 11:38 ` Vladimir Simonov
2011-03-05 12:45 ` Kai Tietz
2011-03-23 11:16 ` Kai Tietz
2011-03-23 12:44 ` Mark Kettenis
2011-03-23 14:07 ` Kai Tietz
2011-03-23 14:16 ` Pedro Alves
2011-03-23 14:18 ` Kai Tietz
2011-03-23 14:29 ` Pierre Muller
[not found] ` <-544184502231544940@unknownmsgid>
2011-03-23 14:44 ` Kai Tietz
2011-03-23 15:29 ` Pedro Alves [this message]
2011-03-23 15:29 ` Kai Tietz
2011-03-23 18:24 ` Eli Zaretskii
2011-03-23 21:11 ` Kai Tietz
2011-03-03 17:02 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103231444.34735.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox