From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org, pierre.muller@ics-cnrs.unistra.fr
Subject: Re: [RFC] Remove START_INFERIOR_TRAPS_EXPECTED macro from nm header
Date: Tue, 22 Mar 2011 11:00:00 -0000 [thread overview]
Message-ID: <201103221023.p2MANXYX027907@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <201103220934.26493.pedro@codesourcery.com> (message from Pedro Alves on Tue, 22 Mar 2011 09:34:26 +0000)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 22 Mar 2011 09:34:26 +0000
>
> Why's this any better? I claim that it's worse.
> START_INFERIOR_TRAPS_EXPECTED isn't ever used by anything
> outside of the native target backend implementation ---
> it doesn't qualify in the set of macros that are evil for
> a multi-arch gdb. Then, nothing in common code _should_
> know about how many internal traps are expected
> during startup_inferior, but you've just exposed that
> detail with to_start_inferior_traps_expected.
I have to agree with Pedro here.
If you really think that getting rid of the nm header files is
something that has to be done (I'm not convinced it is), then perhaps
you should simply add:
MH_CFLAGS=-DSTART_INFERIOR_TRAPS_EXPECTED=3
to the appropriate Makefile fragments. I'm not convinced that is an
improvmenet though.
next prev parent reply other threads:[~2011-03-22 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 9:38 Pierre Muller
2011-03-22 9:41 ` Pedro Alves
2011-03-22 9:59 ` Pierre Muller
2011-03-22 10:05 ` Pedro Alves
2011-03-22 11:00 ` Mark Kettenis [this message]
2011-03-22 11:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103221023.p2MANXYX027907@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox