From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 597 invoked by alias); 22 Mar 2011 10:25:04 -0000 Received: (qmail 532 invoked by uid 22791); 22 Mar 2011 10:25:03 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Mar 2011 10:24:58 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p2MANZHT022725; Tue, 22 Mar 2011 11:23:35 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p2MANXYX027907; Tue, 22 Mar 2011 11:23:33 +0100 (CET) Date: Tue, 22 Mar 2011 11:00:00 -0000 Message-Id: <201103221023.p2MANXYX027907@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: pedro@codesourcery.com CC: gdb-patches@sourceware.org, pierre.muller@ics-cnrs.unistra.fr In-reply-to: <201103220934.26493.pedro@codesourcery.com> (message from Pedro Alves on Tue, 22 Mar 2011 09:34:26 +0000) Subject: Re: [RFC] Remove START_INFERIOR_TRAPS_EXPECTED macro from nm header References: <003e01cbe825$321015a0$963040e0$@muller@ics-cnrs.unistra.fr> <201103220934.26493.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00989.txt.bz2 > From: Pedro Alves > Date: Tue, 22 Mar 2011 09:34:26 +0000 > > Why's this any better? I claim that it's worse. > START_INFERIOR_TRAPS_EXPECTED isn't ever used by anything > outside of the native target backend implementation --- > it doesn't qualify in the set of macros that are evil for > a multi-arch gdb. Then, nothing in common code _should_ > know about how many internal traps are expected > during startup_inferior, but you've just exposed that > detail with to_start_inferior_traps_expected. I have to agree with Pedro here. If you really think that getting rid of the nm header files is something that has to be done (I'm not convinced it is), then perhaps you should simply add: MH_CFLAGS=-DSTART_INFERIOR_TRAPS_EXPECTED=3 to the appropriate Makefile fragments. I'm not convinced that is an improvmenet though.