From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Andrew Burgess <aburgess@broadcom.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Clear GREP_OPTIONS environment variable.
Date: Wed, 16 Mar 2011 16:57:00 -0000 [thread overview]
Message-ID: <20110316161435.GR31264@adacore.com> (raw)
In-Reply-To: <m3d3lr5bqy.fsf@fleche.redhat.com>
> Andrew> The test gdb.base/maint.exp shells out from gdb to use grep. I
> Andrew> have GREP_OPTIONS="--color=auto" in my environment and this
> Andrew> causes the test to fail. The patch below clears this environment
> Andrew> variable before running gdb. Ok to apply?
>
> Andrew> 2011-03-15 Andrew Burgess <aburgess@broadcom.com>
> Andrew> * lib/gdb.exp (default_gdb_start): Clear the GREP_OPTIONS
> Andrew> environment variable to make grep output more predictable.
>
> Ok.
I think that this is OK too. However, I'm wondering whether, as
a followup, we should be moving this type of code to the gdb_init
routine, rather than putting it there. The idea is to run this
once per testcase, rather than once everytime we start a new GDB
process.
--
Joel
next prev parent reply other threads:[~2011-03-16 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 10:13 Andrew Burgess
2011-03-16 15:43 ` Tom Tromey
2011-03-16 16:57 ` Joel Brobecker [this message]
2011-03-17 11:25 ` Andrew Burgess
2011-03-25 15:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316161435.GR31264@adacore.com \
--to=brobecker@adacore.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox