From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6931 invoked by alias); 16 Mar 2011 16:14:50 -0000 Received: (qmail 6869 invoked by uid 22791); 16 Mar 2011 16:14:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Mar 2011 16:14:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 406C42BB010; Wed, 16 Mar 2011 12:14:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hvk523WpdSsL; Wed, 16 Mar 2011 12:14:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 001222BB00A; Wed, 16 Mar 2011 12:14:38 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 10A7F1459B0; Wed, 16 Mar 2011 20:14:35 +0400 (RET) Date: Wed, 16 Mar 2011 16:57:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Andrew Burgess , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Clear GREP_OPTIONS environment variable. Message-ID: <20110316161435.GR31264@adacore.com> References: <4D807468.8020703@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00856.txt.bz2 > Andrew> The test gdb.base/maint.exp shells out from gdb to use grep. I > Andrew> have GREP_OPTIONS="--color=auto" in my environment and this > Andrew> causes the test to fail. The patch below clears this environment > Andrew> variable before running gdb. Ok to apply? > > Andrew> 2011-03-15 Andrew Burgess > Andrew> * lib/gdb.exp (default_gdb_start): Clear the GREP_OPTIONS > Andrew> environment variable to make grep output more predictable. > > Ok. I think that this is OK too. However, I'm wondering whether, as a followup, we should be moving this type of code to the gdb_init routine, rather than putting it there. The idea is to run this once per testcase, rather than once everytime we start a new GDB process. -- Joel