Re: [PATCH] sim: tests: support .S files

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1244 bytes --]

On Monday, March 14, 2011 07:56:23 Pedro Alves wrote:
> On Sunday 13 March 2011 23:10:48, Mike Frysinger wrote:
> > -       set comp_output [target_assemble $sourcefile ${name}.o
> > "$as_options $global_as_options"]
> > +       if [string match "*.S" $sourcefile] {
> > +           set comp_output [target_compile $sourcefile ${name}.s
> > "preprocess" "incdir=$srcdir/$subdir"]
> > +           if ![string match "" $comp_output] {
> > +               verbose -log "$comp_output" 3
> > +               fail "$mach $testname (preprocessing)"
> > +               continue
> > +           }
> > +           set comp_output [target_assemble ${name}.s ${name}.o
> > "$as_options $global_as_options"]
> > +           file delete ${name}.s
> > +       } else {
> > +           set comp_output [target_assemble $sourcefile ${name}.o
> > "$as_options $global_as_options"]
> > +       }
> 
> When using srcdir==buildir, won't this overwrite the source file on
> non case-sensitive filesystems?

picking any diff named file runs the risk of collision.  i have a local patch 
to follow this up to add support for .c files too, but i guess i'll just fold 
them into one since the .c step goes .c -> .o without the .s step.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]