From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15624 invoked by alias); 14 Mar 2011 20:50:05 -0000 Received: (qmail 15610 invoked by uid 22791); 14 Mar 2011 20:50:04 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 20:49:54 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 8B27E1B412F; Mon, 14 Mar 2011 20:49:52 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH] sim: tests: support .S files Date: Mon, 14 Mar 2011 21:06:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.37.3; KDE/4.6.0; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1300057848-2316-1-git-send-email-vapier@gentoo.org> <201103141156.23648.pedro@codesourcery.com> In-Reply-To: <201103141156.23648.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart8983465.tkdC55F7m6"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201103141649.50396.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00747.txt.bz2 --nextPart8983465.tkdC55F7m6 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-length: 1233 On Monday, March 14, 2011 07:56:23 Pedro Alves wrote: > On Sunday 13 March 2011 23:10:48, Mike Frysinger wrote: > > - set comp_output [target_assemble $sourcefile ${name}.o > > "$as_options $global_as_options"] > > + if [string match "*.S" $sourcefile] { > > + set comp_output [target_compile $sourcefile ${name}.s > > "preprocess" "incdir=3D$srcdir/$subdir"] > > + if ![string match "" $comp_output] { > > + verbose -log "$comp_output" 3 > > + fail "$mach $testname (preprocessing)" > > + continue > > + } > > + set comp_output [target_assemble ${name}.s ${name}.o > > "$as_options $global_as_options"] > > + file delete ${name}.s > > + } else { > > + set comp_output [target_assemble $sourcefile ${name}.o > > "$as_options $global_as_options"] > > + } >=20 > When using srcdir=3D=3Dbuildir, won't this overwrite the source file on > non case-sensitive filesystems? picking any diff named file runs the risk of collision. i have a local pat= ch=20 to follow this up to add support for .c files too, but i guess i'll just fo= ld=20 them into one since the .c step goes .c -> .o without the .s step. -mike --nextPart8983465.tkdC55F7m6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJNfn9uAAoJEEFjO5/oN/WBNVwP/R1oAOY6YYjtJMM6odvZ2Qs/ Lpl6Xu0brpaDIHBpGULsonw1lOb9XbW4rKDW+T1krEmqPrlDBVi6Go2mTi3SEzcA iy12W7gZA2zu1wctC7J0FulBOvQ351mYfSXHRrVeug/XogCJh7e7p7deqmzyor/d FEbgTjG0H2pYaJd2NK75yHuG087ibYr1uAuobKnx+hyYWHQU55oW+H2uepdbxxbN t1WZUNgjN0L6g3Wm5k+dNPKDSyahOtsCmRp9flKPRy44397V8zv+UYw6qoCUoMJH 4rN0ZdA4Fl6IQFw1ZPdzFrJfBJKIEI3Ja2SYboR5ZiCUlkTep/9pIE0z/0gUIXfg AK8zGahaAE/qxes2iV+agFB5QzfqwTA/YClmLqInFqBooK1O7oQg1nXgQ0mbVY36 WleAAFPhdGtWBHvweBy83cAMQs2U74Btv3s9FGuh1bIsGumxU4JJCHQ6LC6Kcc2u e0W10f8XnyfV4RiYfm1AXSfX5AvksX/TonWAJ2AH4XB+y04cSDusvUkRMWXlUfnT AD6WGsvYX/36cv6gzVCfLdl4ap1M9TaQ6jQh+QebvItO1cnDf7nEY+VUjE50M42M +SHKFojVRDhurHcqdfLj6gIaQ8XURZwyi1I4VuXTq56p6Z59uQyvhAelIyOlNW2o kT+Mz+qMnn1NA49blvV+ =iAWp -----END PGP SIGNATURE----- --nextPart8983465.tkdC55F7m6--