Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gdb-patches@sourceware.org
Subject: [RFC] Skip hardware breakpoint tests on OpenBSD
Date: Wed, 09 Mar 2011 17:13:00 -0000	[thread overview]
Message-ID: <201103091629.p29GTPeU019522@glazunov.sibelius.xs4all.nl> (raw)

The recently introduced skip_hw_breakpoint_tests procedure is a bit
flawed.  It lists hardware platforms that have hardware breakpoints,
but doesn't take into account that the OS running on those platforms
has to make that functionality available to GDB.  This isn't the case
on OpenBSD (and perhaps some other operating systems as well).  The
diff below makes sure the tests are skipped on OpenBSD.  However,
perhaps instead of whitelisting generic hardware platforms, we should
whitelis explicit hardware/OS combinations here?

Thoughts?

2011-03-09  Mark Kettenis  <kettenis@gnu.org>

        * lib/gdb.exp (skip_hw_breakpoint_tests): None of the OpenBSD
        targets actually implement hardware breakpoints, so return 1 for
        *-*-openbsd*.

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.167
diff -u -p -r1.167 gdb.exp
--- lib/gdb.exp	9 Mar 2011 14:17:05 -0000	1.167
+++ lib/gdb.exp	9 Mar 2011 16:20:41 -0000
@@ -1795,6 +1795,11 @@ proc skip_hw_breakpoint_tests {} {
 	return 1
     }
 
+    # These targets don't support hardware breakpints
+    if { [istarget "*-*-openbsd*"] } {
+	return 1
+    }
+
     # These targets support hardware breakpoints natively
     if { [istarget "i?86-*-*"] 
 	 || [istarget "x86_64-*-*"]


             reply	other threads:[~2011-03-09 16:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 17:13 Mark Kettenis [this message]
2011-03-10  4:41 ` Ulrich Weigand
2011-03-10  7:33   ` Eli Zaretskii
2011-03-10 18:31     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103091629.p29GTPeU019522@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox