From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6097 invoked by alias); 9 Mar 2011 16:29:37 -0000 Received: (qmail 6082 invoked by uid 22791); 9 Mar 2011 16:29:36 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 16:29:31 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p29GTREE008053 for ; Wed, 9 Mar 2011 17:29:27 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p29GTPeU019522; Wed, 9 Mar 2011 17:29:25 +0100 (CET) Date: Wed, 09 Mar 2011 17:13:00 -0000 Message-Id: <201103091629.p29GTPeU019522@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: gdb-patches@sourceware.org Subject: [RFC] Skip hardware breakpoint tests on OpenBSD Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00609.txt.bz2 The recently introduced skip_hw_breakpoint_tests procedure is a bit flawed. It lists hardware platforms that have hardware breakpoints, but doesn't take into account that the OS running on those platforms has to make that functionality available to GDB. This isn't the case on OpenBSD (and perhaps some other operating systems as well). The diff below makes sure the tests are skipped on OpenBSD. However, perhaps instead of whitelisting generic hardware platforms, we should whitelis explicit hardware/OS combinations here? Thoughts? 2011-03-09 Mark Kettenis * lib/gdb.exp (skip_hw_breakpoint_tests): None of the OpenBSD targets actually implement hardware breakpoints, so return 1 for *-*-openbsd*. Index: lib/gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.167 diff -u -p -r1.167 gdb.exp --- lib/gdb.exp 9 Mar 2011 14:17:05 -0000 1.167 +++ lib/gdb.exp 9 Mar 2011 16:20:41 -0000 @@ -1795,6 +1795,11 @@ proc skip_hw_breakpoint_tests {} { return 1 } + # These targets don't support hardware breakpints + if { [istarget "*-*-openbsd*"] } { + return 1 + } + # These targets support hardware breakpoints natively if { [istarget "i?86-*-*"] || [istarget "x86_64-*-*"]