From: Joel Brobecker <brobecker@adacore.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: Include dir intl when building libcommon.a for gdb
Date: Fri, 04 Mar 2011 05:55:00 -0000 [thread overview]
Message-ID: <20110304055520.GE30306@adacore.com> (raw)
In-Reply-To: <AANLkTi=Z1kXKyQp5wPv3eNJPg1pohyESmyJMaeSN1=Tf@mail.gmail.com>
> Hmm, not sure if it helps. But this missing -I ../../intl bugged me
> already for a while.
> I used the following patch in Makefile.in in gdb/common/ and I've
> added it to the INCLUDES.
>
> ChangeLog
>
> * common/Makfile.in (INCLUDES): Add -I for intl.
Could you give the initial error message? Was it when building
GDB or GDBserver?
I am going to guess that this was when you were building GDB?
GDBserver does not seem to include intl, as far as I can tell, so
it would suggest, as pointed out by Pedro, that this should be
put in GDB_INCLUDE instead?
But this also suggests that we have some other code that is in
common/ and should not be there. Your patch may fix the symptoms,
but we'll need to look at the root cause as well.
> Index: gdb/common/Makefile.in
> ===================================================================
> --- gdb.orig/common/Makefile.in 2011-03-02 13:20:22.000000000 +0100
> +++ gdb/common/Makefile.in 2011-03-02 13:25:05.509719100 +0100
> @@ -31,7 +31,7 @@ BFD_DIR = ../../bfd
> BFD_SRC = $(srcdir)/$(BFD_DIR)
> BFD_CFLAGS = -I$(BFD_DIR) -I$(BFD_SRC)
>
> -INCLUDES = -I. -I../ -I$(srcdir) -I$(srcdir)/../../include @GDB_INCLUDE@
> +INCLUDES = -I. -I../ -I../../intl -I$(srcdir) -I$(srcdir)/../../include @GDB_INCLUDE@
>
> libcommon_a_OBJS = signals.o $(COMMON_CPU_OBJ)
> libcommon_a_SOURCES = signals.c $(COMMON_CPU_SRC)
--
Joel
next prev parent reply other threads:[~2011-03-04 5:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 6:22 Yao Qi
2011-03-02 12:14 ` Joel Brobecker
2011-03-02 12:34 ` Kai Tietz
2011-03-04 5:55 ` Joel Brobecker [this message]
2011-03-02 12:44 ` Pedro Alves
2011-03-04 5:46 ` Joel Brobecker
2011-03-02 13:12 ` Mark Kettenis
2011-03-02 14:46 ` Yao Qi
2011-03-02 15:32 ` Pedro Alves
2011-03-03 3:15 ` Yao Qi
2011-03-03 5:40 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304055520.GE30306@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ktietz70@googlemail.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox