From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17882 invoked by alias); 4 Mar 2011 05:55:46 -0000 Received: (qmail 17871 invoked by uid 22791); 4 Mar 2011 05:55:44 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SARE_SUB_RAND_LETTRS4 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 05:55:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2B4092BB189; Fri, 4 Mar 2011 00:55:39 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nvrAV0tPSiCZ; Fri, 4 Mar 2011 00:55:39 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9F2552BB187; Fri, 4 Mar 2011 00:55:38 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DA8321459AD; Fri, 4 Mar 2011 09:55:20 +0400 (RET) Date: Fri, 04 Mar 2011 05:55:00 -0000 From: Joel Brobecker To: Kai Tietz Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: Include dir intl when building libcommon.a for gdb Message-ID: <20110304055520.GE30306@adacore.com> References: <4D6C90AC.9010003@codesourcery.com> <20110302121407.GO30306@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00250.txt.bz2 > Hmm, not sure if it helps. But this missing -I ../../intl bugged me > already for a while. > I used the following patch in Makefile.in in gdb/common/ and I've > added it to the INCLUDES. > > ChangeLog > > * common/Makfile.in (INCLUDES): Add -I for intl. Could you give the initial error message? Was it when building GDB or GDBserver? I am going to guess that this was when you were building GDB? GDBserver does not seem to include intl, as far as I can tell, so it would suggest, as pointed out by Pedro, that this should be put in GDB_INCLUDE instead? But this also suggests that we have some other code that is in common/ and should not be there. Your patch may fix the symptoms, but we'll need to look at the root cause as well. > Index: gdb/common/Makefile.in > =================================================================== > --- gdb.orig/common/Makefile.in 2011-03-02 13:20:22.000000000 +0100 > +++ gdb/common/Makefile.in 2011-03-02 13:25:05.509719100 +0100 > @@ -31,7 +31,7 @@ BFD_DIR = ../../bfd > BFD_SRC = $(srcdir)/$(BFD_DIR) > BFD_CFLAGS = -I$(BFD_DIR) -I$(BFD_SRC) > > -INCLUDES = -I. -I../ -I$(srcdir) -I$(srcdir)/../../include @GDB_INCLUDE@ > +INCLUDES = -I. -I../ -I../../intl -I$(srcdir) -I$(srcdir)/../../include @GDB_INCLUDE@ > > libcommon_a_OBJS = signals.o $(COMMON_CPU_OBJ) > libcommon_a_SOURCES = signals.c $(COMMON_CPU_SRC) -- Joel