* [RFA] aoutx.h, aout_final_link, use sizeof int
@ 2011-03-03 18:25 Michael Snyder
2011-03-03 22:16 ` Alan Modra
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-03-03 18:25 UTC (permalink / raw)
To: nickc, gdb-patches, bug-binutils
[-- Attachment #1: Type: text/plain, Size: 83 bytes --]
Nick,
Seems to me it should be sizeof int, not int*.
What do you think?
Michael
[-- Attachment #2: aoutx.txt --]
[-- Type: text/plain, Size: 962 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* aoutx.txt (aout_final_link): Use sizeof int not sizeof int*.
Index: aoutx.h
===================================================================
RCS file: /cvs/src/src/bfd/aoutx.h,v
retrieving revision 1.85
diff -u -p -u -p -r1.85 aoutx.h
--- aoutx.h 13 Dec 2010 01:06:15 -0000 1.85
+++ aoutx.h 3 Mar 2011 18:22:42 -0000
@@ -5448,7 +5448,7 @@ NAME (aout, final_link) (bfd *abfd,
/* Allocate buffers to hold section contents and relocs. */
aout_info.contents = (bfd_byte *) bfd_malloc (max_contents_size);
aout_info.relocs = bfd_malloc (max_relocs_size);
- aout_info.symbol_map = (int *) bfd_malloc (max_sym_count * sizeof (int *));
+ aout_info.symbol_map = (int *) bfd_malloc (max_sym_count * sizeof (int));
aout_info.output_syms = (struct external_nlist *)
bfd_malloc ((max_sym_count + 1) * sizeof (struct external_nlist));
if ((aout_info.contents == NULL && max_contents_size != 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] aoutx.h, aout_final_link, use sizeof int
2011-03-03 18:25 [RFA] aoutx.h, aout_final_link, use sizeof int Michael Snyder
@ 2011-03-03 22:16 ` Alan Modra
2011-03-03 23:47 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2011-03-03 22:16 UTC (permalink / raw)
To: Michael Snyder; +Cc: nickc, gdb-patches, bug-binutils
On Thu, Mar 03, 2011 at 10:25:31AM -0800, Michael Snyder wrote:
> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>
> * aoutx.txt (aout_final_link): Use sizeof int not sizeof int*.
aoutx.h. OK.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] aoutx.h, aout_final_link, use sizeof int
2011-03-03 22:16 ` Alan Modra
@ 2011-03-03 23:47 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2011-03-03 23:47 UTC (permalink / raw)
To: Michael Snyder, nickc, gdb-patches, bug-binutils
Alan Modra wrote:
> On Thu, Mar 03, 2011 at 10:25:31AM -0800, Michael Snyder wrote:
>> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>>
>> * aoutx.txt (aout_final_link): Use sizeof int not sizeof int*.
>
> aoutx.h. OK.
>
Committed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-03 23:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-03 18:25 [RFA] aoutx.h, aout_final_link, use sizeof int Michael Snyder
2011-03-03 22:16 ` Alan Modra
2011-03-03 23:47 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox