From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] bfd-target.c, target_bfd_reopen, check for error
Date: Wed, 02 Mar 2011 01:26:00 -0000 [thread overview]
Message-ID: <201103020126.18408.pedro@codesourcery.com> (raw)
In-Reply-To: <4D6D9748.7080608@vmware.com>
On Wednesday 02 March 2011 01:03:04, Michael Snyder wrote:
> This is the only instance in which build_section_table is called
> without being checked for error return.
>
> OK?
build_section_table actually always returns '0' (==success)...
It can throw, though currently only through an internal_error.
The correct thing to do would be to make it return void,
and change all the dead error handling to do cleanups instead
of checking build_section_table's return.
--
Pedro Alves
prev parent reply other threads:[~2011-03-02 1:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 1:03 Michael Snyder
2011-03-02 1:26 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103020126.18408.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox