From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25683 invoked by alias); 2 Mar 2011 01:26:28 -0000 Received: (qmail 25672 invoked by uid 22791); 2 Mar 2011 01:26:28 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 01:26:22 +0000 Received: (qmail 23468 invoked from network); 2 Mar 2011 01:26:20 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Mar 2011 01:26:20 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] bfd-target.c, target_bfd_reopen, check for error Date: Wed, 02 Mar 2011 01:26:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D6D9748.7080608@vmware.com> In-Reply-To: <4D6D9748.7080608@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103020126.18408.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00078.txt.bz2 On Wednesday 02 March 2011 01:03:04, Michael Snyder wrote: > This is the only instance in which build_section_table is called > without being checked for error return. > > OK? build_section_table actually always returns '0' (==success)... It can throw, though currently only through an internal_error. The correct thing to do would be to make it return void, and change all the dead error handling to do cleanups instead of checking build_section_table's return. -- Pedro Alves