From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] add_symbol_file_command, avoid memory leak.
Date: Sun, 27 Feb 2011 20:51:00 -0000 [thread overview]
Message-ID: <20110227204206.GA11932@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <4D6AB5A2.3030807@vmware.com>
On Sun, 27 Feb 2011 21:35:46 +0100, Michael Snyder wrote:
> Jan Kratochvil wrote:
> > While a nitpick it is a regression, that dont_repeat should be called even
> > in the case of that error.
>
> No, it's a fix. I moved the error before dont_repeat.
Why? The manual says:
`add-symbol-file' does not repeat if you press <RET> after using it.
Other part of the manual says:
and you can repeat certain GDB commands by typing just <RET>.
There is nothing said that whether the command is / is not repated depends on
its entered arguments.
(Not sure if it matters to continue the discussion, I do not mind either way.)
Regards,
Jan
next prev parent reply other threads:[~2011-02-27 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 1:56 Michael Snyder
2011-02-27 20:35 ` Jan Kratochvil
2011-02-27 20:42 ` Michael Snyder
2011-02-27 20:51 ` Jan Kratochvil [this message]
2011-02-27 22:00 ` Michael Snyder
2011-02-27 22:12 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110227204206.GA11932@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox