From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11948 invoked by alias); 27 Feb 2011 20:42:19 -0000 Received: (qmail 11940 invoked by uid 22791); 27 Feb 2011 20:42:18 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Feb 2011 20:42:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1RKg9Fl024100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 27 Feb 2011 15:42:09 -0500 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1RKg7Z0006797 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 27 Feb 2011 15:42:08 -0500 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p1RKg6UG018190; Sun, 27 Feb 2011 21:42:06 +0100 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id p1RKg658018185; Sun, 27 Feb 2011 21:42:06 +0100 Date: Sun, 27 Feb 2011 20:51:00 -0000 From: Jan Kratochvil To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [rfa] add_symbol_file_command, avoid memory leak. Message-ID: <20110227204206.GA11932@host1.dyn.jankratochvil.net> References: <4D69AAFC.6030607@vmware.com> <20110227171301.GA16297@host1.dyn.jankratochvil.net> <4D6AB5A2.3030807@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D6AB5A2.3030807@vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00839.txt.bz2 On Sun, 27 Feb 2011 21:35:46 +0100, Michael Snyder wrote: > Jan Kratochvil wrote: > > While a nitpick it is a regression, that dont_repeat should be called even > > in the case of that error. > > No, it's a fix. I moved the error before dont_repeat. Why? The manual says: `add-symbol-file' does not repeat if you press after using it. Other part of the manual says: and you can repeat certain GDB commands by typing just . There is nothing said that whether the command is / is not repated depends on its entered arguments. (Not sure if it matters to continue the discussion, I do not mind either way.) Regards, Jan