From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] Make get_number_or_range accept value history references
Date: Sat, 26 Feb 2011 11:54:00 -0000 [thread overview]
Message-ID: <201102261152.24496.pedro@codesourcery.com> (raw)
In-Reply-To: <4D682303.5040809@vmware.com>
On Friday 25 February 2011 21:45:39, Michael Snyder wrote:
> OK, a major re-write! ;-)
Thanks.
I now noticed linespec.c:decode_dollar also does
the same thing, another candidate for refactoring/reuse.
What does the _ref mean in value_from_history_ref?
> +gdb_test "disable \$1foo" \
> + "Convenience variable must have integer value.*" \
> + "disable with badly formed history value"
This is not a badly formed history value. It's a user
convenience variable. I'd make the test check that
such convenience variables work as intended.
Otherwise looked fine. Thanks again.
--
Pedro Alves
next prev parent reply other threads:[~2011-02-26 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 19:12 Michael Snyder
2011-02-25 11:59 ` Pedro Alves
2011-02-25 19:20 ` Michael Snyder
2011-02-25 22:10 ` Michael Snyder
2011-02-26 11:54 ` Pedro Alves [this message]
2011-02-27 21:03 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102261152.24496.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox