From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6646 invoked by alias); 26 Feb 2011 11:52:43 -0000 Received: (qmail 6635 invoked by uid 22791); 26 Feb 2011 11:52:42 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 11:52:37 +0000 Received: (qmail 9922 invoked from network); 26 Feb 2011 11:52:35 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Feb 2011 11:52:35 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [rfa] Make get_number_or_range accept value history references Date: Sat, 26 Feb 2011 11:54:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4D66AD46.204@vmware.com> <201102251155.57072.pedro@codesourcery.com> <4D682303.5040809@vmware.com> In-Reply-To: <4D682303.5040809@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102261152.24496.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00789.txt.bz2 On Friday 25 February 2011 21:45:39, Michael Snyder wrote: > OK, a major re-write! ;-) Thanks. I now noticed linespec.c:decode_dollar also does the same thing, another candidate for refactoring/reuse. What does the _ref mean in value_from_history_ref? > +gdb_test "disable \$1foo" \ > + "Convenience variable must have integer value.*" \ > + "disable with badly formed history value" This is not a badly formed history value. It's a user convenience variable. I'd make the test check that such convenience variables work as intended. Otherwise looked fine. Thanks again. -- Pedro Alves