From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] Use get_number_or_range for kill inferior etc.
Date: Fri, 25 Feb 2011 21:45:00 -0000 [thread overview]
Message-ID: <201102252051.36471.pedro@codesourcery.com> (raw)
In-Reply-To: <4D680E45.50607@vmware.com>
On Friday 25 February 2011 20:17:09, Michael Snyder wrote:
> - tp = any_thread_of_process (pid);
> - if (!tp)
> - error (_("Inferior has no threads."));
> + tp = any_thread_of_process (pid);
> + if (!tp)
> + error (_("Inferior has no threads."));
This is fine with me, but I think all the errors should
be updated to include the inferior ID that caused the
trouble.
> error (_("Requires argument (inferior id to detach)"));
Probably want to make these plural as well.
On Friday 25 February 2011 20:17:09, Michael Snyder wrote:
> +gdb_test_no_output "remove-inferior 2-3" "remove-inferior 2-3"
Plural?
If you only have say inferiors 1, 3 and 5, these commands will
error out if you do 'CMD 1-5', claiming 2 or 4 are invalid.
Not sure that's user friendly.
And you'll need to update the docs as well, at least
because you renamed some commands.
--
Pedro Alves
next prev parent reply other threads:[~2011-02-25 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 20:52 Michael Snyder
2011-02-25 21:45 ` Pedro Alves [this message]
2011-02-25 22:30 ` Michael Snyder
2011-02-25 23:16 ` Eli Zaretskii
2011-02-26 2:09 ` Michael Snyder
2011-02-26 10:35 ` Eli Zaretskii
2011-02-26 18:47 ` Michael Snyder
2011-02-26 19:52 ` Eli Zaretskii
2011-02-26 13:53 ` Pedro Alves
2011-02-27 20:57 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102252051.36471.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox