From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3954 invoked by alias); 25 Feb 2011 20:52:54 -0000 Received: (qmail 3946 invoked by uid 22791); 25 Feb 2011 20:52:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Feb 2011 20:52:47 +0000 Received: (qmail 18347 invoked from network); 25 Feb 2011 20:52:45 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Feb 2011 20:52:45 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [rfa] Use get_number_or_range for kill inferior etc. Date: Fri, 25 Feb 2011 21:45:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4D680E45.50607@vmware.com> In-Reply-To: <4D680E45.50607@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102252051.36471.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00780.txt.bz2 On Friday 25 February 2011 20:17:09, Michael Snyder wrote: > - tp = any_thread_of_process (pid); > - if (!tp) > - error (_("Inferior has no threads.")); > + tp = any_thread_of_process (pid); > + if (!tp) > + error (_("Inferior has no threads.")); This is fine with me, but I think all the errors should be updated to include the inferior ID that caused the trouble. > error (_("Requires argument (inferior id to detach)")); Probably want to make these plural as well. On Friday 25 February 2011 20:17:09, Michael Snyder wrote: > +gdb_test_no_output "remove-inferior 2-3" "remove-inferior 2-3" Plural? If you only have say inferiors 1, 3 and 5, these commands will error out if you do 'CMD 1-5', claiming 2 or 4 are invalid. Not sure that's user friendly. And you'll need to update the docs as well, at least because you renamed some commands. -- Pedro Alves