From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95
Date: Mon, 21 Feb 2011 12:52:00 -0000 [thread overview]
Message-ID: <20110221115805.GK2600@adacore.com> (raw)
In-Reply-To: <009301cbd1bd$88ed0550$9ac70ff0$@muller@ics-cnrs.unistra.fr>
> + /* Stop any pending selects. On Windows 95 OS, CancelIo function does not
> + exist. In that case, it can be replaced by a call to CloseHandle, but
> + this is not necessary here as we do close the Windows handle by
> calling
> + close (scb->fd) below. */
Thanks for adding the comment. You forgot to add a second space after
the period on the second line... And while I'm nitpicking (I really
apologize), we had a discussion about line length and sort of agreed
on a "soft" limit of 70 characters, and a hard limit of 79, or 80.
Can you try a little shorter lines? (ironic, I know). I promise,
I wouldn't be nitpicking if you weren't going to touch it :).
--
Joel
next prev parent reply other threads:[~2011-02-21 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 13:06 [RFC] " Compte ICS
2011-02-04 13:57 ` Pierre Muller
2011-02-05 20:38 ` [RFA] " Pierre Muller
2011-02-21 11:06 ` Joel Brobecker
2011-02-21 11:58 ` Pierre Muller
2011-02-21 12:52 ` Joel Brobecker [this message]
2011-02-21 13:35 ` Pierre Muller
2011-02-21 14:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221115805.GK2600@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox