From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23204 invoked by alias); 21 Feb 2011 11:58:20 -0000 Received: (qmail 23195 invoked by uid 22791); 21 Feb 2011 11:58:19 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 11:58:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EF1E62BABF8; Mon, 21 Feb 2011 06:58:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id COfzooGD2IVU; Mon, 21 Feb 2011 06:58:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 852952BABF3; Mon, 21 Feb 2011 06:58:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C2B2C1459B0; Mon, 21 Feb 2011 15:58:05 +0400 (RET) Date: Mon, 21 Feb 2011 12:52:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95 Message-ID: <20110221115805.GK2600@adacore.com> References: <001201cbc46c$5b95b100$12c11300$@muller@ics-cnrs.unistra.fr> <000001cbc473$6ef9d120$4ced7360$@muller@ics-cnrs.unistra.fr> <002401cbc574$a8d990e0$fa8cb2a0$@muller@ics-cnrs.unistra.fr> <20110221102151.GG2600@adacore.com> <009301cbd1bd$88ed0550$9ac70ff0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <009301cbd1bd$88ed0550$9ac70ff0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00540.txt.bz2 > + /* Stop any pending selects. On Windows 95 OS, CancelIo function does not > + exist. In that case, it can be replaced by a call to CloseHandle, but > + this is not necessary here as we do close the Windows handle by > calling > + close (scb->fd) below. */ Thanks for adding the comment. You forgot to add a second space after the period on the second line... And while I'm nitpicking (I really apologize), we had a discussion about line length and sort of agreed on a "soft" limit of 70 characters, and a hard limit of 79, or 80. Can you try a little shorter lines? (ironic, I know). I promise, I wouldn't be nitpicking if you weren't going to touch it :). -- Joel