Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [unavailable values part 1, 05/17] move traceframe memory reading fallback to read-only sections to GDB side
Date: Tue, 15 Feb 2011 17:28:00 -0000	[thread overview]
Message-ID: <201102151724.45355.pedro@codesourcery.com> (raw)
In-Reply-To: <20110214120008.GE2454@host1.dyn.jankratochvil.net>

Continuing addressing your review piecemeal...

On Tuesday 15 February 2011 12:00:08, Jan Kratochvil wrote:
> On Mon, 07 Feb 2011 15:30:29 +0100, Pedro Alves wrote:
> > +/* Using the set of read-only target sections of OPS, read live
> > +   read-only memory.  Note that the actual reads start from the
> > +   top-most target again.  */
> 
> /* The return is the same as that of target_read.  */
> 
> > +
> > +static LONGEST
> > +memory_xfer_live_readonly_partial (struct target_ops *ops,

Thanks.  I've applied the below, memory_xfer_partial already
uses the same style.

Pedro Alves

2011-02-15  Pedro Alves  <pedro@codesourcery.com>
	    Jan Kratochvil  <jan.kratochvil@redhat.com>

	gdb/
	* target.c (memory_xfer_live_readonly_partial): Document where to
	look for interface description.

---
 gdb/target.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: src/gdb/target.c
===================================================================
--- src.orig/gdb/target.c	2011-02-14 11:21:27.000000000 +0000
+++ src/gdb/target.c	2011-02-15 16:16:38.418123003 +0000
@@ -1297,7 +1297,10 @@ target_read_live_memory (enum target_obj
 
 /* Using the set of read-only target sections of OPS, read live
    read-only memory.  Note that the actual reads start from the
-   top-most target again.  */
+   top-most target again.
+
+   For interface/parameters/return description see target.h,
+   to_xfer_partial.  */
 
 static LONGEST
 memory_xfer_live_readonly_partial (struct target_ops *ops,


      reply	other threads:[~2011-02-15 17:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 14:30 Pedro Alves
2011-02-14 11:46 ` Pedro Alves
2011-02-14 12:00 ` Jan Kratochvil
2011-02-15 17:28   ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102151724.45355.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox