From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31558 invoked by alias); 15 Feb 2011 17:24:57 -0000 Received: (qmail 31534 invoked by uid 22791); 15 Feb 2011 17:24:56 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Feb 2011 17:24:52 +0000 Received: (qmail 17898 invoked from network); 15 Feb 2011 17:24:50 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Feb 2011 17:24:50 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [unavailable values part 1, 05/17] move traceframe memory reading fallback to read-only sections to GDB side Date: Tue, 15 Feb 2011 17:28:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Jan Kratochvil References: <201102071430.29773.pedro@codesourcery.com> <20110214120008.GE2454@host1.dyn.jankratochvil.net> In-Reply-To: <20110214120008.GE2454@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102151724.45355.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00327.txt.bz2 Continuing addressing your review piecemeal... On Tuesday 15 February 2011 12:00:08, Jan Kratochvil wrote: > On Mon, 07 Feb 2011 15:30:29 +0100, Pedro Alves wrote: > > +/* Using the set of read-only target sections of OPS, read live > > + read-only memory. Note that the actual reads start from the > > + top-most target again. */ > > /* The return is the same as that of target_read. */ > > > + > > +static LONGEST > > +memory_xfer_live_readonly_partial (struct target_ops *ops, Thanks. I've applied the below, memory_xfer_partial already uses the same style. Pedro Alves 2011-02-15 Pedro Alves Jan Kratochvil gdb/ * target.c (memory_xfer_live_readonly_partial): Document where to look for interface description. --- gdb/target.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: src/gdb/target.c =================================================================== --- src.orig/gdb/target.c 2011-02-14 11:21:27.000000000 +0000 +++ src/gdb/target.c 2011-02-15 16:16:38.418123003 +0000 @@ -1297,7 +1297,10 @@ target_read_live_memory (enum target_obj /* Using the set of read-only target sections of OPS, read live read-only memory. Note that the actual reads start from the - top-most target again. */ + top-most target again. + + For interface/parameters/return description see target.h, + to_xfer_partial. */ static LONGEST memory_xfer_live_readonly_partial (struct target_ops *ops,