From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
Subject: Re: No longer accept NULL values in value_bits_valid and value_bits_synthetic_pointer
Date: Mon, 14 Feb 2011 16:00:00 -0000 [thread overview]
Message-ID: <201102141527.p1EFRc0c022596@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <201102141519.39403.pedro@codesourcery.com> (message from Pedro Alves on Mon, 14 Feb 2011 15:19:39 +0000)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Mon, 14 Feb 2011 15:19:39 +0000
>
> On Monday 14 February 2011 14:50:23, Mark Kettenis wrote:
> > > 2011-02-14 Pedro Alves <pedro@codesourcery.com>
> > >
> > > * value.c (value_bits_valid, value_bits_synthetic_pointer):
> > > No longer handle NULL values.
> >
> > Would it be a good idea to add a gdb_assert() here to check for a NULL pointer?
>
> I considered it, but then didn't add it. None of the
> other value_ functions does that before dereferencing
> the value. There aren't many places these functions are
> called, and, I still plan on putting an assertion like
> that in a few more central places, near the roots of
> the val_print & co call chains, which should cover
> this as well.
Fair enough. Diff looks reasonable to me.
prev parent reply other threads:[~2011-02-14 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 11:56 Pedro Alves
2011-02-14 11:58 ` Pedro Alves
2011-02-14 15:17 ` Mark Kettenis
2011-02-14 15:29 ` Pedro Alves
2011-02-14 16:00 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102141527.p1EFRc0c022596@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox