From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: Re: [unavailable values part 1, 01/17] base support for unavailable value contents
Date: Mon, 14 Feb 2011 11:45:00 -0000 [thread overview]
Message-ID: <201102141145.31043.pedro@codesourcery.com> (raw)
In-Reply-To: <m38vxml1k0.fsf@fleche.redhat.com>
On Monday 14 February 2011 21:10:55, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> Yeah, I don't expect to have more than a handful of ranges to work with.
> Pedro> But in any case, I've done that change. Below's my current patch.
> Pedro> WDYT?
>
> Looks great.
>
> Tom> This could also use a binary search. Again, maybe not worth the effort.
>
> Pedro> Also done. I've added some "pictures" in the comments, but I'm
> Pedro> not sure if that's overboard.
>
> M-x artist-mode FTW :-)
> Seriously, though, looks good to me.
:-)
Thanks for the review. I've checked it in.
--
Pedro Alves
next prev parent reply other threads:[~2011-02-14 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 14:28 Pedro Alves
2011-02-07 15:47 ` Tom Tromey
2011-02-10 18:46 ` Pedro Alves
2011-02-10 19:30 ` Pedro Alves
2011-02-14 11:59 ` Jan Kratochvil
2011-02-14 13:18 ` Pedro Alves
2011-02-14 17:28 ` Jan Kratochvil
2011-02-11 21:11 ` Tom Tromey
2011-02-14 11:45 ` Pedro Alves [this message]
2011-02-08 4:17 ` Joel Brobecker
2011-02-10 18:53 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102141145.31043.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox