From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31695 invoked by alias); 14 Feb 2011 11:45:44 -0000 Received: (qmail 31677 invoked by uid 22791); 14 Feb 2011 11:45:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Feb 2011 11:45:36 +0000 Received: (qmail 28272 invoked from network); 14 Feb 2011 11:45:34 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Feb 2011 11:45:34 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [unavailable values part 1, 01/17] base support for unavailable value contents Date: Mon, 14 Feb 2011 11:45:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Tom Tromey References: <201102071427.55970.pedro@codesourcery.com> <201102101846.38823.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102141145.31043.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00256.txt.bz2 On Monday 14 February 2011 21:10:55, Tom Tromey wrote: > >>>>> "Pedro" == Pedro Alves writes: > > Pedro> Yeah, I don't expect to have more than a handful of ranges to work with. > Pedro> But in any case, I've done that change. Below's my current patch. > Pedro> WDYT? > > Looks great. > > Tom> This could also use a binary search. Again, maybe not worth the effort. > > Pedro> Also done. I've added some "pictures" in the comments, but I'm > Pedro> not sure if that's overboard. > > M-x artist-mode FTW :-) > Seriously, though, looks good to me. :-) Thanks for the review. I've checked it in. -- Pedro Alves