From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>, Tom Tromey <tromey@redhat.com>
Subject: Re: FYI: add user_breakpoint_p
Date: Tue, 01 Feb 2011 15:21:00 -0000 [thread overview]
Message-ID: <201102011522.08804.pedro@codesourcery.com> (raw)
In-Reply-To: <20110201030544.GH2384@adacore.com>
On Tuesday 01 February 2011 03:05:44, Joel Brobecker wrote:
> > >> - if (!user_settable_breakpoint (tp) || tp->number < 0)
> > >> + if (! user_breakpoint_p (tp))
> >
> > Joel> Do we agree on whether to write this as the above, or whether we should
> > Joel> not have a space between the '!' and the expression being negated:
> >
> > I have trouble remembering whether we have a rule here.
> > I will remove the space. It doesn't matter to me either way if we have
> > it or not.
>
> It doesn't matter to me either way, althought I have a slight preference
> for no space. I'd like us to agree and make a "soft" recommendation on
> my wiki page about the GDB Coding Style.
I still have in my queue to post a patch per:
<http://sourceware.org/ml/gdb-patches/2010-11/msg00121.html>
If you guys are still okay with it, I'll bump it close to the
the top of my today's TODO. (I'm okay with having this in
the wiki as well).
--
Pedro Alves
next prev parent reply other threads:[~2011-02-01 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 5:52 Tom Tromey
2011-01-31 2:10 ` Joel Brobecker
2011-01-31 15:11 ` Tom Tromey
2011-02-01 3:05 ` Joel Brobecker
2011-02-01 14:31 ` Tom Tromey
2011-02-01 15:21 ` Pedro Alves [this message]
2011-02-02 14:42 ` Tom Tromey
2011-02-03 4:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102011522.08804.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox