From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1597 invoked by alias); 1 Feb 2011 15:21:53 -0000 Received: (qmail 1588 invoked by uid 22791); 1 Feb 2011 15:21:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Feb 2011 15:21:48 +0000 Received: (qmail 19567 invoked from network); 1 Feb 2011 15:21:46 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Feb 2011 15:21:46 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: FYI: add user_breakpoint_p Date: Tue, 01 Feb 2011 15:21:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.5.1; x86_64; ; ) Cc: Joel Brobecker , Tom Tromey References: <20110201030544.GH2384@adacore.com> In-Reply-To: <20110201030544.GH2384@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102011522.08804.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00005.txt.bz2 On Tuesday 01 February 2011 03:05:44, Joel Brobecker wrote: > > >> - if (!user_settable_breakpoint (tp) || tp->number < 0) > > >> + if (! user_breakpoint_p (tp)) > > > > Joel> Do we agree on whether to write this as the above, or whether we should > > Joel> not have a space between the '!' and the expression being negated: > > > > I have trouble remembering whether we have a rule here. > > I will remove the space. It doesn't matter to me either way if we have > > it or not. > > It doesn't matter to me either way, althought I have a slight preference > for no space. I'd like us to agree and make a "soft" recommendation on > my wiki page about the GDB Coding Style. I still have in my queue to post a patch per: If you guys are still okay with it, I'll bump it close to the the top of my today's TODO. (I'm okay with having this in the wiki as well). -- Pedro Alves