From: Pedro Alves <pedro@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: s/regcache_valid_p/regcache_register_status; add enum register_status
Date: Sun, 30 Jan 2011 19:11:00 -0000 [thread overview]
Message-ID: <201101301150.49147.pedro@codesourcery.com> (raw)
In-Reply-To: <4D44D91F.6030504@codesourcery.com>
On Sunday 30 January 2011 03:21:03, Yao Qi wrote:
> On 01/25/2011 08:49 PM, Pedro Alves wrote:
> > 2011-01-25 Pedro Alves <pedro@codesourcery.com>
> >
> > * regcache.c (struct regcache_descr): Rename
> [....]
> > (regcache_valid_p): Rename to ...
> > (regcache_register_status): ... this. Adjust.
>
> All the references to regcache_valid_p should be updated as well.
Aaww, completely missed that.
> GDB native build on ARM is broken.
> cc1: warnings being treated as errors
> ../../src/gdb/arm-linux-nat.c: In function store_fpregister:
> ../../src/gdb/arm-linux-nat.c:193: error: implicit declaration of
> function regcache_valid_p
>
> This patch is to s/regcache_valid_p/regcache_register_status in the rest
> of gdb source files, and fix ARM native build failure.
>
> OK to apply?
Not as is. Please use 'if (regcache_register_status (..) == REG_VALID)'
instead of 'if (regcache_register_status (..)'. Okay with that
change.
Thanks!
--
Pedro Alves
next prev parent reply other threads:[~2011-01-30 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 14:18 Pedro Alves
2011-01-30 11:50 ` Yao Qi
2011-01-30 19:11 ` Pedro Alves [this message]
2011-01-30 23:31 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101301150.49147.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox