From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24149 invoked by alias); 30 Jan 2011 11:50:59 -0000 Received: (qmail 24140 invoked by uid 22791); 30 Jan 2011 11:50:58 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Jan 2011 11:50:54 +0000 Received: (qmail 32653 invoked from network); 30 Jan 2011 11:50:52 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Jan 2011 11:50:52 -0000 From: Pedro Alves To: Yao Qi Subject: Re: s/regcache_valid_p/regcache_register_status; add enum register_status Date: Sun, 30 Jan 2011 19:11:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.5.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201101251249.04269.pedro@codesourcery.com> <4D44D91F.6030504@codesourcery.com> In-Reply-To: <4D44D91F.6030504@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201101301150.49147.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00566.txt.bz2 On Sunday 30 January 2011 03:21:03, Yao Qi wrote: > On 01/25/2011 08:49 PM, Pedro Alves wrote: > > 2011-01-25 Pedro Alves > > > > * regcache.c (struct regcache_descr): Rename > [....] > > (regcache_valid_p): Rename to ... > > (regcache_register_status): ... this. Adjust. > > All the references to regcache_valid_p should be updated as well. Aaww, completely missed that. > GDB native build on ARM is broken. > cc1: warnings being treated as errors > ../../src/gdb/arm-linux-nat.c: In function store_fpregister: > ../../src/gdb/arm-linux-nat.c:193: error: implicit declaration of > function regcache_valid_p > > This patch is to s/regcache_valid_p/regcache_register_status in the rest > of gdb source files, and fix ARM native build failure. > > OK to apply? Not as is. Please use 'if (regcache_register_status (..) == REG_VALID)' instead of 'if (regcache_register_status (..)'. Okay with that change. Thanks! -- Pedro Alves