Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: yao@codesourcery.com (Yao Qi)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, arm] Consistent display of registers in corefile
Date: Thu, 13 Jan 2011 16:04:00 -0000	[thread overview]
Message-ID: <201101131555.p0DFtdIs002421@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <4D2EF249.6010308@codesourcery.com> from "Yao Qi" at Jan 13, 2011 06:38:33 AM

Yao Qi wrote:

> FPS belongs to float_reggroup, save_reggroup, and restore_reggroup, 
> instead of float_reggroup only.

> +  /* FPS register's type is INT, but belongs to float_reggroup,
> +     save_regroup, and restore_reggroup.  */
>    if (regnum == ARM_FPS_REGNUM)
> -    return (group == float_reggroup);
> +    return (group == float_reggroup
> +	    || group == save_reggroup
> +	    || group == restore_reggroup);
>    else
>      return default_register_reggroup_p (gdbarch, regnum, group);

Well, FPS should also belong to all_reggroup, otherwise it wil not
show up in "info all-registers" ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2011-01-13 15:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 13:37 Yao Qi
2010-12-10 14:46 ` Mark Kettenis
2010-12-10 15:07   ` Yao Qi
2010-12-13  2:57   ` Daniel Jacobowitz
2010-12-13 10:00     ` Yao Qi
2010-12-19 18:24       ` Daniel Jacobowitz
2010-12-20  2:29         ` Yao Qi
2010-12-20  3:09           ` Daniel Jacobowitz
2011-01-13 13:45 ` Yao Qi
2011-01-13 16:04   ` Ulrich Weigand [this message]
2011-01-13 16:47     ` Yao Qi
2011-01-14 16:52       ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101131555.p0DFtdIs002421@d06av02.portsmouth.uk.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox