From: Daniel Jacobowitz <dan@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [patch, arm] Consistent display of registers in corefile
Date: Sun, 19 Dec 2010 18:24:00 -0000 [thread overview]
Message-ID: <20101219182358.GA7961@caradoc.them.org> (raw)
In-Reply-To: <4D05EEC0.7030200@codesourcery.com>
On Mon, Dec 13, 2010 at 06:00:32PM +0800, Yao Qi wrote:
> On 12/13/2010 10:57 AM, Daniel Jacobowitz wrote:
> > On Fri, Dec 10, 2010 at 03:43:15PM +0100, Mark Kettenis wrote:
> >> I would suspect that the proper thing to do would be to align the
> >> tdesc with the code instead of the other way around. The arm-core.xml
> >> file seems to underspecify things by omitting the type=xxx clause on
> >> many registers. Whoever wrote arm_register_type() at least had to
> >> make a conscious decision about the signedness of the type used for
> >> the general purpose registers.
> >
> > Yeah, I agree. It was probably my mistake.
> >
>
> In this new patch, 'type="uint32"' is added for registers from r0 to r12
> except r11. r11 is 'type="data_ptr"'. features/arm*.c files are
> regenerated by Makefile. Regression tested along with the other patch
> arm_fps_group.patch on armv7l-unknown-linux-gnueabi, "corefile restored
> general registers" failure in gdb.base/gcore.exp goes away. Is it OK
> for GDB mainline?
Please use uint32 for r11 also. It's sometimes the frame pointer, but
that's not required and it may have any arbitrary data in it.
Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-12-19 18:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 13:37 Yao Qi
2010-12-10 14:46 ` Mark Kettenis
2010-12-10 15:07 ` Yao Qi
2010-12-13 2:57 ` Daniel Jacobowitz
2010-12-13 10:00 ` Yao Qi
2010-12-19 18:24 ` Daniel Jacobowitz [this message]
2010-12-20 2:29 ` Yao Qi
2010-12-20 3:09 ` Daniel Jacobowitz
2011-01-13 13:45 ` Yao Qi
2011-01-13 16:04 ` Ulrich Weigand
2011-01-13 16:47 ` Yao Qi
2011-01-14 16:52 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101219182358.GA7961@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox