From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: check asprintf return values
Date: Wed, 12 Jan 2011 21:24:00 -0000 [thread overview]
Message-ID: <20110112212311.GG2504@adacore.com> (raw)
In-Reply-To: <201101121306.14814.vapier@gentoo.org>
> > * sim-module.c (sim_pre_argv_init): Return SIM_RC_FAIL when asprintf
> > fails.
> > * sim-options.c (sim_parse_args): Issue an error and return SIM_RC_FAIL
> > when asprintf fails.
> > * sim-utils.c (sim_do_commandf): Issue an error and return when
> > asprintf fails.
> > * sim-watch.c (sim_watchpoint_install): Return SIM_RC_FAIL when
> > asprintf fails.
Sorry for the delay in the review. This looks OK to me.
--
Joel
next prev parent reply other threads:[~2011-01-12 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 21:24 Mike Frysinger
2011-01-12 18:15 ` Mike Frysinger
2011-01-12 21:24 ` Joel Brobecker [this message]
2011-01-12 22:05 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112212311.GG2504@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox