From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7190 invoked by alias); 12 Jan 2011 21:23:20 -0000 Received: (qmail 7182 invoked by uid 22791); 12 Jan 2011 21:23:20 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Jan 2011 21:23:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6D1342BABC4; Wed, 12 Jan 2011 16:23:13 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2EcTrB8Vrrl8; Wed, 12 Jan 2011 16:23:13 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9A4F82BAB88; Wed, 12 Jan 2011 16:23:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A7C071459AD; Wed, 12 Jan 2011 16:23:11 -0500 (EST) Date: Wed, 12 Jan 2011 21:24:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] sim: check asprintf return values Message-ID: <20110112212311.GG2504@adacore.com> References: <1293743311-13288-1-git-send-email-vapier@gentoo.org> <201101121306.14814.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201101121306.14814.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00280.txt.bz2 > > * sim-module.c (sim_pre_argv_init): Return SIM_RC_FAIL when asprintf > > fails. > > * sim-options.c (sim_parse_args): Issue an error and return SIM_RC_FAIL > > when asprintf fails. > > * sim-utils.c (sim_do_commandf): Issue an error and return when > > asprintf fails. > > * sim-watch.c (sim_watchpoint_install): Return SIM_RC_FAIL when > > asprintf fails. Sorry for the delay in the review. This looks OK to me. -- Joel