[PATCH] Detect GNU/kFreeBSD and set osabi appropiately

[PATCH] Detect GNU/kFreeBSD and set osabi appropiately

[Robert Millan]

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Thank you.  Would you please consider this one too?

(ChangeLog entry in patch header)

-- 
Robert Millan

[-- Attachment #2: osabi.diff --]
[-- Type: text/plain, Size: 593 bytes --]

2011-01-09  Robert Millan  <rmh@gnu.org>

	* configure.tgt: Detect GNU/kFreeBSD and set `gdb_osabi'
	appropiately.

=== modified file 'gdb/configure.tgt'
--- gdb/configure.tgt	2010-12-29 16:15:40 +0000
+++ gdb/configure.tgt	2011-01-08 10:40:17 +0000
@@ -629,7 +629,8 @@ esac
 # map target onto default OS ABI
 
 case "${targ}" in
-*-*-freebsd*)	gdb_osabi=GDB_OSABI_FREEBSD_ELF ;;
+*-*-freebsd* | *-*-kfreebsd*-gnu)
+		gdb_osabi=GDB_OSABI_FREEBSD_ELF ;;
 *-*-linux*)	gdb_osabi=GDB_OSABI_LINUX ;;
 *-*-nto*)	gdb_osabi=GDB_OSABI_QNXNTO ;;
 m68*-*-openbsd* | m88*-*-openbsd* | vax-*-openbsd*) ;;

Re: [PATCH] Detect GNU/kFreeBSD and set osabi appropiately

[Joel Brobecker]

> Thank you.  Would you please consider this one too?
> (ChangeLog entry in patch header)

Sure! That looks fine (I just double-checked that config.sub
accepts it).

> 2011-01-09  Robert Millan  <rmh@gnu.org>
> 
> 	* configure.tgt: Detect GNU/kFreeBSD and set `gdb_osabi'
> 	appropiately.

Are you considering sending more patches? It might be easier for
everyone if you get "Write After Approval" priviledges.  That means
that you have commit priviledges for the patches you send if they
are approved by one of the GDB Maintainers (see gdb/MAINTAINERS
for more info).

Would you be interested? We'd need a copyright assignment first,
if you don't have one (I don't see one).

-- 
Joel

Re: [PATCH] Detect GNU/kFreeBSD and set osabi appropiately

[Robert Millan]

2011/1/12 Joel Brobecker <brobecker@adacore.com>:
> Sure! That looks fine (I just double-checked that config.sub
> accepts it).

Thank you!

> Are you considering sending more patches? It might be easier for
> everyone if you get "Write After Approval" priviledges.

I also sent: "[PATCH] gdb for GNU/kFreeBSD on MIPS"

This is likely my last patch.  Thanks for the offer but I don't
think I'll be needing an account (would be nice if you can
review/commit my last patch however ;-)).

> We'd need a copyright assignment first,
> if you don't have one (I don't see one).

Crap, I thought I had a GDB assignment.  My changes untill
now are very small, but if you think it's worth it I'm fine with
signing one for past and future changes.

Cheers

-- 
Robert Millan

Re: [PATCH] Detect GNU/kFreeBSD and set osabi appropiately

[Joel Brobecker]

> I also sent: "[PATCH] gdb for GNU/kFreeBSD on MIPS"
> 
> This is likely my last patch.  Thanks for the offer but I don't
> think I'll be needing an account (would be nice if you can
> review/commit my last patch however ;-)).

Unfortunately, your last patch is a little over the "small patch"
limit in terms of size, and is definitely not in the "obvious fix"
category. So I think that you'll need a copyright assignment in
any case (I was badly jetlagged and fatigued yesterday, so I missed
that patch).

> Crap, I thought I had a GDB assignment.  My changes untill
> now are very small, but if you think it's worth it I'm fine with
> signing one for past and future changes.

I just couldn't find it. You could ask the FSF clerk to confirm,
and if not, to send you the initial electronic form (I can send
you the form too, but you'll probably want to double-check with
them).

-- 
Joel

Re: [PATCH] Detect GNU/kFreeBSD and set osabi appropiately

[Joel Brobecker]

> 2011-01-09  Robert Millan  <rmh@gnu.org>
> 
> 	* configure.tgt: Detect GNU/kFreeBSD and set `gdb_osabi'
> 	appropiately.

I just checked this patch in.

-- 
Joel