From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New testcase arm-disp-step.exp
Date: Thu, 23 Dec 2010 04:38:00 -0000 [thread overview]
Message-ID: <20101223041625.GR2596@adacore.com> (raw)
In-Reply-To: <4D10B005.8020002@codesourcery.com>
> testsuite/
>
> * gdb.arch/arm-disp-step.exp: New.
> * gdb.arch/arm-disp-step.S: New.
Comments below...
> +# Get things started.
> +
> +gdb_exit
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
Use "clean_restart"....
> +# which is in library might be compiled in Thumb.
> +gdb_test "set displaced-stepping off" ""
Use gdb_test_no_output.
> +gdb_test "set displaced-stepping on" ""
Same here.
> +gdb_test_multiple "continue" "continue to test_call" {
> + -re ".*bl test_call_subr.*" {
> + pass "continue to test_call"
> + }
> + -re "Displaced stepping is only supported in" {
> + xfail $testfile
> + return
I'm not sure about the xfail. Why did you decide to use it?
I thought we were supposed to use kfail in this case, since this is
a debugger issue? xfail should be used when the failure is caused
by the debugging environment (compiler bug, missing feature in kernel,
etc).
--
Joel
next prev parent reply other threads:[~2010-12-23 4:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 13:48 Yao Qi
2010-12-23 4:38 ` Joel Brobecker [this message]
2010-12-23 9:11 ` Yao Qi
2010-12-23 17:56 ` Joel Brobecker
2010-12-24 8:34 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223041625.GR2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox