From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29180 invoked by alias); 23 Dec 2010 04:16:43 -0000 Received: (qmail 29172 invoked by uid 22791); 23 Dec 2010 04:16:43 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Dec 2010 04:16:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 71DC72BACC5; Wed, 22 Dec 2010 23:16:37 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4JnbEwYnz2-a; Wed, 22 Dec 2010 23:16:37 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 03DA22BACBF; Wed, 22 Dec 2010 23:16:36 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 106E51457B3; Thu, 23 Dec 2010 05:16:25 +0100 (CET) Date: Thu, 23 Dec 2010 04:38:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: New testcase arm-disp-step.exp Message-ID: <20101223041625.GR2596@adacore.com> References: <4D10B005.8020002@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D10B005.8020002@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00424.txt.bz2 > testsuite/ > > * gdb.arch/arm-disp-step.exp: New. > * gdb.arch/arm-disp-step.S: New. Comments below... > +# Get things started. > + > +gdb_exit > +gdb_start > +gdb_reinitialize_dir $srcdir/$subdir > +gdb_load ${binfile} Use "clean_restart".... > +# which is in library might be compiled in Thumb. > +gdb_test "set displaced-stepping off" "" Use gdb_test_no_output. > +gdb_test "set displaced-stepping on" "" Same here. > +gdb_test_multiple "continue" "continue to test_call" { > + -re ".*bl test_call_subr.*" { > + pass "continue to test_call" > + } > + -re "Displaced stepping is only supported in" { > + xfail $testfile > + return I'm not sure about the xfail. Why did you decide to use it? I thought we were supposed to use kfail in this case, since this is a debugger issue? xfail should be used when the failure is caused by the debugging environment (compiler bug, missing feature in kernel, etc). -- Joel