From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] mips-tdep.c: Fix mips16 bit rot
Date: Tue, 14 Dec 2010 05:39:00 -0000 [thread overview]
Message-ID: <20101214053915.GI2596@adacore.com> (raw)
In-Reply-To: <20101213170635.6f0c4356@mesquite.lan>
> Comments?
>
> * mips-tdep.c (make_mips16_addr): New function.
> (mips_elf_make_msymbol_special): Don't set the low bit in the
> symbol's address.
> (mips_read_pc, mips_unwind_pc, mips_addr_bits_remove): Strip bit
> indicating mips16 address, if present.
> (mips_write_pc): Set bit indicating mips16 address when in a mips16
> function.
> (mips_eabi_push_dummy_call, mips_o64_push_dummy_call): Likewise,
> but for each function pointer argument to inferior function call.
I'm not a mips expert, but the changes look reasonable to me, and they
should only affect mips16 (at least in theory). I'd probably wait a few
more days to give others a chance to comment, but it otherwise seems OK
to me.
--
Joel
next prev parent reply other threads:[~2010-12-14 5:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 0:06 Kevin Buettner
2010-12-14 5:39 ` Joel Brobecker [this message]
2010-12-17 21:40 ` Kevin Buettner
2011-11-23 12:41 ` Maciej W. Rozycki
2011-12-14 23:24 ` Kevin Buettner
2012-05-14 20:11 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214053915.GI2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox