From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21966 invoked by alias); 14 Dec 2010 05:39:44 -0000 Received: (qmail 21705 invoked by uid 22791); 14 Dec 2010 05:39:42 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 05:39:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AC6BE2BAB68; Tue, 14 Dec 2010 00:39:27 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 45gZzYGyrKeq; Tue, 14 Dec 2010 00:39:27 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3ED152BAB1C; Tue, 14 Dec 2010 00:39:27 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8A852145B58; Tue, 14 Dec 2010 06:39:15 +0100 (CET) Date: Tue, 14 Dec 2010 05:39:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] mips-tdep.c: Fix mips16 bit rot Message-ID: <20101214053915.GI2596@adacore.com> References: <20101213170635.6f0c4356@mesquite.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101213170635.6f0c4356@mesquite.lan> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00206.txt.bz2 > Comments? > > * mips-tdep.c (make_mips16_addr): New function. > (mips_elf_make_msymbol_special): Don't set the low bit in the > symbol's address. > (mips_read_pc, mips_unwind_pc, mips_addr_bits_remove): Strip bit > indicating mips16 address, if present. > (mips_write_pc): Set bit indicating mips16 address when in a mips16 > function. > (mips_eabi_push_dummy_call, mips_o64_push_dummy_call): Likewise, > but for each function pointer argument to inferior function call. I'm not a mips expert, but the changes look reasonable to me, and they should only affect mips16 (at least in theory). I'd probably wait a few more days to give others a chance to comment, but it otherwise seems OK to me. -- Joel