Re: [patch, testsuite] General ARM target triplet

[Pedro Alves <pedro@codesourcery.com>]

On Sunday 05 December 2010 12:42:40, Yao Qi wrote:
> On 12/05/2010 05:39 PM, Andreas Schwab wrote:
> > Yao Qi <yao@codesourcery.com> writes:
> > 
> >>  # This test can only be run on targets which support DWARF-2 and use gas.
> >>  # For now pick a sampling of likely targets.
> >> -if {![istarget *-*-linux*]
> >> -    && ![istarget *-*-gnu*]
> >> -    && ![istarget *-*-elf*]
> >> -    && ![istarget *-*-openbsd*]
> >> -    && ![istarget arm-*-eabi*]
> >> -    && ![istarget powerpc-*-eabi*]} {
> >> +if {![dwarf2_support]} {
> >>      return 0  
> >>  }
> > 
> > The second sentence of the comment no longer fits and should probably be
> > deleted.
> > 
> 
> No wonder I was confused by it a little when I read that comment. :)
> 
> The second sentence is removed by this (2nd) patch, which depends on the
> first patch.

I think it would have been easier if you had just posted this as
an updated version of the first patch.

> diff --git a/gdb/testsuite/gdb.dwarf2/watch-notconst.exp b/gdb/testsuite/gdb.dwarf2/watch-notconst.exp
> index ccc398f..b499d3a 100644
> --- a/gdb/testsuite/gdb.dwarf2/watch-notconst.exp
> +++ b/gdb/testsuite/gdb.dwarf2/watch-notconst.exp
> @@ -17,7 +17,6 @@ load_lib dwarf.exp
>  set test "watch-notconst"
>  
>  # This test can only be run on targets which support DWARF-2 and use gas.
> -# For now pick a sampling of likely targets.
>  if ![dwarf2_support] {
>      return 0  
>  }

> diff --git a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp
> index de537d0..abf2791 100644
> --- a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp
> +++ b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp
> @@ -15,7 +15,6 @@
>  
>  load_lib dwarf.exp
>  # This test can only be run on targets which support DWARF-2 and use gas.
> -# For now pick a sampling of likely targets.
>  load_lib mi-support.exp
>  set MIFLAGS "-i=mi"
>  

> diff --git a/gdb/testsuite/gdb.python/py-section-script.exp b/gdb/testsuite/gdb.python/py-section-script.exp
> index 434dca4..373c450 100644
> --- a/gdb/testsuite/gdb.python/py-section-script.exp
> +++ b/gdb/testsuite/gdb.python/py-section-script.exp
> @@ -17,7 +17,6 @@
>  # scripts specified in the .debug_gdb_scripts section.
>  
>  # This test can only be run on targets which support ELF and use gas.
> -# For now pick a sampling of likely targets.
>  if {![istarget *-*-linux*]
>      && ![istarget *-*-gnu*]
>      && ![istarget *-*-elf*]

If the "support ELF" comment is correct (as opposed to "support DWARF-2" in
the other cases), then you should not remove this one.

Back in the first patch:

On Sunday 05 December 2010 12:15:09, Yao Qi wrote:
> +# This test can only be run on targets which support DWARF-2 and use gas.
> +proc dwarf2_support {} {

There's no "This test" anymore.  Maybe:

# Return true if the target supports DWARF-2 and uses gas.
# For now pick a sampling of likely targets.

> +    if {![istarget *-*-linux*]
> +       && ![istarget *-*-gnu*]
> +       && ![istarget *-*-elf*]
> +       && ![istarget *-*-openbsd*]
> +       && ![istarget arm*-*-eabi*]
> +       && ![istarget arm*-*-symbianelf*]
> +       && ![istarget powerpc-*-eabi*]} {
> +       return 0
> +    }
> +
> +    return 1
> +}

-- 
Pedro Alves