From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18384 invoked by alias); 13 Dec 2010 14:07:18 -0000 Received: (qmail 18368 invoked by uid 22791); 13 Dec 2010 14:07:17 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Dec 2010 14:07:12 +0000 Received: (qmail 11013 invoked from network); 13 Dec 2010 14:07:10 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Dec 2010 14:07:10 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch, testsuite] General ARM target triplet Date: Mon, 13 Dec 2010 14:07:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Yao Qi , Andreas Schwab , Richard Earnshaw , "Joseph S. Myers" References: <4CF91BD4.7090708@codesourcery.com> <4CFB88C0.1040703@codesourcery.com> In-Reply-To: <4CFB88C0.1040703@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201012131407.08185.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00180.txt.bz2 On Sunday 05 December 2010 12:42:40, Yao Qi wrote: > On 12/05/2010 05:39 PM, Andreas Schwab wrote: > > Yao Qi writes: > > > >> # This test can only be run on targets which support DWARF-2 and use gas. > >> # For now pick a sampling of likely targets. > >> -if {![istarget *-*-linux*] > >> - && ![istarget *-*-gnu*] > >> - && ![istarget *-*-elf*] > >> - && ![istarget *-*-openbsd*] > >> - && ![istarget arm-*-eabi*] > >> - && ![istarget powerpc-*-eabi*]} { > >> +if {![dwarf2_support]} { > >> return 0 > >> } > > > > The second sentence of the comment no longer fits and should probably be > > deleted. > > > > No wonder I was confused by it a little when I read that comment. :) > > The second sentence is removed by this (2nd) patch, which depends on the > first patch. I think it would have been easier if you had just posted this as an updated version of the first patch. > diff --git a/gdb/testsuite/gdb.dwarf2/watch-notconst.exp b/gdb/testsuite/gdb.dwarf2/watch-notconst.exp > index ccc398f..b499d3a 100644 > --- a/gdb/testsuite/gdb.dwarf2/watch-notconst.exp > +++ b/gdb/testsuite/gdb.dwarf2/watch-notconst.exp > @@ -17,7 +17,6 @@ load_lib dwarf.exp > set test "watch-notconst" > > # This test can only be run on targets which support DWARF-2 and use gas. > -# For now pick a sampling of likely targets. > if ![dwarf2_support] { > return 0 > } > diff --git a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp > index de537d0..abf2791 100644 > --- a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp > +++ b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp > @@ -15,7 +15,6 @@ > > load_lib dwarf.exp > # This test can only be run on targets which support DWARF-2 and use gas. > -# For now pick a sampling of likely targets. > load_lib mi-support.exp > set MIFLAGS "-i=mi" > > diff --git a/gdb/testsuite/gdb.python/py-section-script.exp b/gdb/testsuite/gdb.python/py-section-script.exp > index 434dca4..373c450 100644 > --- a/gdb/testsuite/gdb.python/py-section-script.exp > +++ b/gdb/testsuite/gdb.python/py-section-script.exp > @@ -17,7 +17,6 @@ > # scripts specified in the .debug_gdb_scripts section. > > # This test can only be run on targets which support ELF and use gas. > -# For now pick a sampling of likely targets. > if {![istarget *-*-linux*] > && ![istarget *-*-gnu*] > && ![istarget *-*-elf*] If the "support ELF" comment is correct (as opposed to "support DWARF-2" in the other cases), then you should not remove this one. Back in the first patch: On Sunday 05 December 2010 12:15:09, Yao Qi wrote: > +# This test can only be run on targets which support DWARF-2 and use gas. > +proc dwarf2_support {} { There's no "This test" anymore. Maybe: # Return true if the target supports DWARF-2 and uses gas. # For now pick a sampling of likely targets. > + if {![istarget *-*-linux*] > + && ![istarget *-*-gnu*] > + && ![istarget *-*-elf*] > + && ![istarget *-*-openbsd*] > + && ![istarget arm*-*-eabi*] > + && ![istarget arm*-*-symbianelf*] > + && ![istarget powerpc-*-eabi*]} { > + return 0 > + } > + > + return 1 > +} -- Pedro Alves